Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add option to reconnect if connack has an error code #1948

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: add option to reconnect if connack has an error code #1948

wants to merge 4 commits into from

Conversation

mgabeler-lee-6rs
Copy link

@mgabeler-lee-6rs mgabeler-lee-6rs commented Oct 16, 2024 •
edited
Loading

fixes #1947

  • Not sure about the naming of the new option
  • New option defaulting disabled to avoid surprise in consumers, but there's an argument to defaulting it on
  • Needs tests
  • Add documentation

@mgabeler-lee-6rs mgabeler-lee-6rs mentioned this pull request Oct 16, 2024
Open
robertsLando
robertsLando reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option name looks good to me. Remember to add tests and also docs

@mgabeler-lee-6rs mgabeler-lee-6rs marked this pull request as ready for review October 16, 2024 15:31
@mgabeler-lee-6rs
Copy link
Author

mgabeler-lee-6rs commented Oct 16, 2024 •
edited
Loading

@robertsLando ✔️

I noticed the first pass the CI tests failed for various reasons that ... don't seem related to any changes I made? Esp. the internal error within the codecov uploader.

Edit: new runs failed the same way

@robertsLando
Copy link
Member

@mgabeler-lee-6rs I still don't understand why ci fails, could you try removing the test and push? Just to see if that's the reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando Awaiting requested review from robertsLando

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Does not start reconnect timer on connection error
2 participants
@mgabeler-lee-6rs @robertsLando