-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS/input: simpler solution to handle sh metacharacters with run #9647
base: master
Are you sure you want to change the base?
Conversation
509375d
to
9b72e47
Compare
Not sure about this. While technically correct, it's a bit misleading in two ways:
Also, the text is a bit too verbose for my taste with the metacharacters etc. It's suffice IMHO to say that it avoid the need for escaping the actual value. Overall, the text should be shorter and without gotchas. |
Yeah, I am aware I should have used There I was just trying to shorten the line as much as possible since that line is indented a lot and it is hard to read on a 80x24 terminal window. But, you are right that that could be misleading. I will add it back since the line won't fit on one line in a small terminal anyway. I also would not have mentioned the "potential code injection attack", but I did since it was already mentioned in the original text, I will happily remove it. I will make the note less verbose and add an addendum for |
a0898c8
to
2eab3a5
Compare
That would work, but looks clumsy IMHO (it is a matter of taste though), and if more arguments are used then it becomes messier. Maybe something like The single quotes prevent string escpes interpretation (backslash), the Also, you should ignore the terminal width. The manpage is aligned it to the terminal width automatically, and except for example strings which preferably fit to 60 chars or so, all other text should be arbitrary. Don't "design" for manpage in 80 cols term. |
2eab3a5
to
1bf831e
Compare
I rebased the commit onto |
Also rephrase "To get the old behavior" as "If you want to use shell features".
I changed the commit message to |
Relevant: Had to find out Test string Please consider a update. |
Also rephrase "To get the old behavior" as "If you want to use shell features".
Screenshot: