autocrop and vf-metadata improvements #752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavfi would segfault due to a NULL dereference if it was asked for its metadata and none had been allocated (oops). This happens for libav which has no concept of filter metadata.
It might have been nice not to do this so that metadata could accumulate accross seeks, but it seems libavfilter looses its copy anyway on recreate_graph.
It now inserts no filters and does nothing until the hot-key is pressed. This makes it more suitable to be put in ~/.mpv/lua. When they hot-key is pressed, it now removes any existing crop filter and inserts the cropdetect filter. It then samples the whole file to determine crop parameters and uses them to insert the new crop filter. The cropdetect filter is then removed and the original file position restored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important thing here is the bugfix to properly handle NULL metadata (libav). I've also enhanced autocrop.lua. It is now suitable to put in ~/.mpv/lua as it does nothing until asked. It also samples the whole file to determine appropriate crop parameters (the only bullet-proof method).
I'll understand though if you'd rather keep that commit out as it makes the script significantly more complex. On the other hand, it demos more of mpv's lua capabilities.