osc: only clear thumbnails when hiding#17954
Conversation
this currently disables thumbnail even on set_visible(true) calls which was causing flickering due when scrubbing through the timeline. only disable thumbnail when hiding the osc. Fixes: 9ce79bc
|
ping: @guidocella |
| local function osc_visible(visible) | ||
| set_bar_visible("osc_visible", visible) | ||
| disable_thumbnail() | ||
| if not visible then |
There was a problem hiding this comment.
What if thumbnail should be shown when visible=true, why ignore?
There was a problem hiding this comment.
What if thumbnail should be shown when visible=true, why ignore?
This should be handled by the ui drawing code already.
But more importantly, I noticed that going into visibility never doesn't even clear the thumbnail, even on master.
There was a problem hiding this comment.
This should be handled by the ui drawing code already.
Yeah this doesn't work either. You need to actively move your mouse to retrigger the thumbnail.
There was a problem hiding this comment.
But more importantly, I noticed that going into visibility never doesn't even clear the thumbnail, even on
master.
Should be fixed now.
There was a problem hiding this comment.
This should be handled by the ui drawing code already.
Yeah this doesn't work either. You need to actively move your mouse to retrigger the thumbnail.
If you go from visibility never -> auto, then the osc itself doesn't redraw either without moving the mouse manually. This seems like a deeper issue with how osc drawing works.
There was a problem hiding this comment.
If you go from visibility never -> auto, then the osc itself doesn't redraw either without moving the mouse manually.
currently hide_bar() bypasses set_visible when visibility was changed to `never`, this can leave the thumbnail hanging. instead of scattering disable_thumbnail() calls around, just call set_visible(false) instead. Fixes: 9ce79bc
currently mouse processing only happens on mouse movement which causes cases where going from never -> auto does not show the osc even though the cursor might be in proximity. move mouse processing code to a function and refresh it when leaving visibility never to avoid such issues. Fixes: mpv-player#17954 (comment)
currently mouse processing only happens on mouse movement which causes cases where going from never -> auto does not show the osc even though the cursor might be in proximity. move mouse processing code to a function and refresh it when leaving visibility never to avoid such issues. Fixes: mpv-player#17954 (comment)
3 participants
this currently disables thumbnail even on set_visible(true) calls which was causing flickering due when scrubbing through the timeline. only disable thumbnail when hiding the osc.
Fixes: 9ce79bc