docs: simple cocoa API usage example #1001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gah, was I wrong to force push a fix? |
|
Github unfortunately detaches the old commit from the issue if you force-push. Normally I'd say force-pushing is correct to update a pull request (especially if the PR consists of multiple separate commits), but github makes it a bit of a pain. Anyway, I just wrote: https://github.com/frau/mpv/commit/6d3af08e0a380b1b9b053d4e6205d71da4d14959#commitcomment-7335138 |
Also, imitate the qt example somewhat.
|
Well, it still uses the dispatch queue stuff, so to me it just looks like it got even more complicated (although I don't understand it fully), and the first version looks shorter/simpler. |
|
It looks more complicated but also more realistic, imho. |
|
So shall I merge this? |
|
Yeah, it looks good to me. |
|
OK, pushed both commits. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't include the basic plist and project file you need to get this to run, but those are just boilerplate generated by Xcode.