-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS and defaults: youtube-dl default format is now bestvideo+bestaudio/best #1867
Comments
OK, the default is now actually "best", instead of letting youtube-dl decide. |
This breaks: It's because the format option takes precedence over the |
In that case, you could use |
@jaimeMF I think that my commit should be reverted then, since people that don't want to waste bandwidth can use that format option instead of letting mpv pass the |
References:
[1] #1321
[2] ytdl-org/youtube-dl#5447
[3] ytdl-org/youtube-dl@feccf29
Issue #1321 proposed to use
bestvideo+bestaudio
as the default format in invoking youtube-dl. Now youtube-dl's default format is bestvideo+bestaudio/best due to the proposal in [2]. As a result, either https://github.com/mpv-player/mpv/blob/master/DOCS/man/options.rst should be updated to conform to the latest changes in youtube-dl, or https://github.com/mpv-player/mpv/blob/master/player/lua/ytdl_hook.lua should enforcebest
format when passsing arguments.Note that such changes are not included in the latest stable release 2015.04.17 yet, but it won't be long due to youtube-dl's rapid release schedule.
The text was updated successfully, but these errors were encountered: