Skip to content

Context menu partially broken in latest mpv builds #15233

@zenwav

Description

@zenwav

mpv Information

mpv v0.39.0-269-g41cff490 Copyright © 2000-2024 mpv/MPlayer/mplayer2 projects
 built on Oct 30 2024 12:06:16
libplacebo version: v7.349.0 (v7.349.0-19-g118d810-dirty)
FFmpeg version: N-117673-gbb57b7801
FFmpeg library versions:
   libavcodec      61.22.100
   libavdevice     61.4.100
   libavfilter     10.6.100
   libavformat     61.9.100
   libavutil       59.46.100
   libswresample   5.4.100
   libswscale      8.9.101

Other Information

- Windows version: Windows 10 22H2 (OS Build 19045.4894)
- GPU model, driver and version: GTX 1660Ti, v537.58 
- Source of mpv: Windows builds by zhongfly (git)
- Introduced in version:

Reproduction Steps

  1. Download dyn_menu.lua from tsl0922/mpv-menu-plugin and place it inside ~/scripts.
  2. Download the example menu configuration file, input.conf, from tsl0922/input.conf and place it inside the portable_config directory.

Expected Behavior

Following the merge of right-click context menu support (#13700), dyn_menu.lua alone should be enough for context menu functionality, without needing menu.dll or dialog.lua to be placed into the ~/scripts folder

Actual Behavior

In the latest mpv builds (GitHub CI, shinchiro Windows build, and zhongfly):

  • The context menu only partially works with the dyn_menu.lua script from the main branch. Right-clicking does bring up a context menu, but clicking options like Open > Files, which should open a file selection dialogue, does not work. This functionality seems to require all three files present in the ~~/scripts directory, contrary to the expected behaviour.
  • Additionally, using the dyn_menu.lua script downloaded from the GitHub releases page results in the context menu failing to display altogether.

Log File

output.txt

Sample Files

No response

I carefully read all instruction and confirm that I did the following:

  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information including system and mpv version.
  • I produced the log file with the exact same set of files, parameters, and conditions used in "Reproduction Steps", with the addition of --log-file=output.txt.
  • I produced the log file while the behaviors described in "Actual Behavior" were actively observed.
  • I attached the full, untruncated log file.
  • I attached the backtrace in the case of a crash.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions