why hdr tone-mapping build is broken when going from mpv 38 to 40?

[geextahslex]

Hi, I have tried the latest mpv 40 and my working hdr build from mpv 38 looks different. What is causing that issue?

Thanks for any help :)

gamut-mapping-mode=clip
tone-mapping=st2094-10
target-peak=100
hdr-compute-peak=yes
allow-delayed-peak-detect=yes
target-prim=bt.2020
target-trc=pq

glsl-shader-opts=L_hdr=1000,L_sdr=100
glsl-shader=~~/shaders/hdr-toys/transfer-function/pq_inv.glsl
glsl-shader=~~/shaders/hdr-toys/utils/black_point_compensation.glsl
glsl-shader=~~/shaders/hdr-toys/gamut-mapping/jedypod.glsl
glsl-shader=~~/shaders/hdr-toys/transfer-function/bt1886.glsl

mpv 40

mpv 38

[geextahslex]

Okay now I know where this weird behavior comes from, if your mpv is in windowed mode and you drag the HDR file onto it, it will look broken, first after you switch to fullscreen something gets "activated or initialized" and it looks normally. I don't know if this is a bug or something, just wanted to let you know.

You can see the change in HDR10: Display:

[kasper93]

Generally this is how auto profiles work, they are asynchronous and act on current values. In many cases current values will be delayed one main loop cycle (one frame in non-dispaly-sync mode). So you might see one frame start with old/default profile. Which should clear on next update. You shouldn't have to toggle fullscreen for this to update. For me it updates immediately.

[geextahslex]

I don't know on mpv 38 it works normally, on 40 I had to add target-colorspace-hint=no to make my HDR build look as intended. I don't know if there is something specific about this setting. Now I have downloded the latest shinchiro build it is still the same, but the greyish OSC/OSD color/tint is now fixed so something has improved.

It is also not about one frame, because I can start playback in this "state"

[kasper93]

Yes, if you are using external shaders to convert colorspace, you have to use target-colorspace-hint=no or target-colorspace-hint=yes, but carefully override all --target-* parameters to ones compatible with output of your shaders. (hint is not possible if shared expect certain input)

I will merge one fix, and you can retest, maybe it will help in your case.

[geextahslex]

I use this combination HDR to SDR tonemapping of hdr-toys and mpv's native tone-mapping (2094-10)
Sure I will test it but I can not compile ^^'

[geextahslex]

@kasper93
It's fixed now with https://github.com/shinchiro/mpv-winbuild-cmake/releases/download/20250815/mpv-x86_64-v3-20250815-git-7653cc8.7z

awesome, thank you :)