You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@lonewasp
Thanks a lot for submitting your patch. However, I am not the maintainer of libldm; I just forked it some time ago in order to submit my patch, just as you have done. Would you be so kind to submit a pull request to mdbooth/libldm? Judging by a number of commits, mdbooth appears to be a maintainer/author of this project. He has been inactive in last months, but hopefully this is only a temporary absence.
Sorry for disturbing you. Just thought these fixes might be interesting to Ubutnu/Debian users. And I really don't think any merges to happen on the "main" master line.
@lonewasp
No problem at all! I still think it would be best if all pull requests go to mdbooth's libldm repo. Even if he abandoned the project, someone else might be willing to create a maintained fork in the future. I don't want to maintain it myself, because that would require more effort that I could spare, and libldm is not at the core of what I am doing. Right now I don't even have a way to test your patches, which is why I haven't merged them.
Anyway, thanks for replying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.