Repository navigation
fix: phase_sigma silent drop + honest audit limits - #11
Merged
Merged
Conversation
phase_noise was previously a silent no-op on the binary path. Binary optical scores remain exact only in the ideal no-noise case. Adds docs/audit_limits.md on what generate-match does and does not prove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix
NoiseConfig(phase_sigma=...)with no positions previously used the binary encoder and ignored phase noise entirely.Docs
docs/audit_limits.mdstates clearly: binary optical = digital by construction; safetensors generate match validates hybrid wiring, not crystal physics.