bindAll throws a reference error if a given method is undefined on th…

…e incoming object
mponizil · Jun 19, 2014 · 900511c · 900511c
1 parent ac647af
commit 900511c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/test/functions.js b/test/functions.js
@@ -82,6 +82,8 @@
 
     raises(function() { _.bindAll(moe); }, Error, 'throws an error for bindAll with no functions named');
 
+    raises(function() { _.bindAll(moe, "sayBye"); }, ReferenceError, 'throws an error for bindAll if the given function is undefined');
+
     _.bindAll(moe, 'sayHi', 'sayLast');
     curly.sayHi = moe.sayHi;
     equal(curly.sayHi(), 'hi: moe');

diff --git a/underscore.js b/underscore.js
@@ -673,6 +673,7 @@
     if (length <= 1) throw Error('bindAll must be passed function names');
     for (; i < length; i++) {
       key = arguments[i];
+      if (_.isUndefined(obj[key])) throw ReferenceError(key + " is not defined");
       obj[key] = createCallback(obj[key], obj, Infinity);
     }
     return obj;