Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Encoders and add JSON support #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

erikgaal
Copy link

Builds upon #83 and refactors it a bit to provide a clear solution. Also rebased the PR so it's up to date with the trunk.

Thanks @lsmith77 for the original PR!

@nonoesp
Copy link
Collaborator

nonoesp commented Jul 29, 2022

Hi, @lsmith77 and @erikgaal I don't have the bandwidth to take on new features and maintain this project.

Would any of you want to help?

These pull requests are a really good start; it's just that I haven't even had time to figure out whether there are parts that break with your changes.

@CoolGoose
Copy link
Contributor

@nonoesp since we're starting to use this more in our company, is there something I can start helping with to review / add tests so we can get some of these things moving forward ? Json support is something we're going to need, and I think it would be nice to do it part of this and not a fork.

@nonoesp
Copy link
Collaborator

nonoesp commented Sep 6, 2024

@CoolGoose Hey! I have limited bandwidth for this. But I'll be happy to chat and let you maintain this package if you'd like. =)

@CoolGoose
Copy link
Contributor

I can give it a try since I should be able to have a few hours per week for this. Let me review this PR first, and see how this goes ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants