43 fix json column double encoding #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 16, 2018 14:32
When a model uses `$casts = ['field' => 'array']` with a JSON field, getAttributes() will return the JSON-encoded string, while $model->fill() expects the input to contain the un-encoded JSON value. So instead, use attributesToArray() to get the model data, which will work properly with fill(). Fixes mpociot#43
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=========================================
Coverage 99.13% 99.13%
Complexity 45 45
=========================================
Files 3 3
Lines 115 115
=========================================
Hits 114 114
Misses 1 1
Continue to review full report at Codecov.
|
|
just for my understanding .. this fix addresses using during the save process, ie. past stored data might be corrupted? if that is the case .. has anyone worked on a solution to clean up corrupted data? |
|
I think you're right. Haven't tested that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although with Postgres the current behavior is double-encoding JSON fields, the test case using SQLite will fail with "unable to serialize Closure" instead. Still, the change fixes the issue for both database systems.