Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use default terminal colors for color pair 0. #31

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

Siborgium
Copy link
Contributor

Title says it all. I use semitransparent terminal emulator and green background looks just ugly. Thus I decided to make quick fix and added option to use default color pair. It won't break any backwards compatibility (colored background is chosen by default), but anyone who prefer default colors for foreground/background are now able to use this option.

@Siborgium
Copy link
Contributor Author

Few screenshots just to make it clear.
Fullscreen semi-transparent window
In-game
Main menu + flags

Copy link
Contributor

@greno4ka greno4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are quite nice for me=)

@greno4ka
Copy link
Contributor

greno4ka commented Jan 7, 2019

I use Guake with semitransparent background too, and this change is quite cool. Also, I think, it's a good idea to add some more beautiful background/foreground schemes. For example dark theme for playing at night=))

@mpereira
Copy link
Owner

mpereira commented Jun 1, 2020

Thanks @Siborgium. I'll merge your PR and release it today.

@mpereira mpereira merged commit 456b66d into mpereira:master Jun 1, 2020
@mpereira
Copy link
Owner

mpereira commented Jun 1, 2020

@Siborgium v1.3.0 was released with your change. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants