Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing issue #3 #20

Merged
merged 2 commits into from
May 7, 2018
Merged

Closing issue #3 #20

merged 2 commits into from
May 7, 2018

Conversation

greno4ka
Copy link
Contributor

@greno4ka greno4ka commented Feb 9, 2018

I found some free time to make some code, that makes a possibility of selecting and deselecting stack faster. I didn't touched greeting for the game, where information about this feature should be placed, I hope, you ll do it and maybe my PR will give you some inspiration to make other features from "issues" tab=)

P.S. I tested this new feature, no problem detected. But as you're a "father" of this game, you can find mistakes in my patch, so pay attention to this code.

@mpereira
Copy link
Owner

mpereira commented Feb 9, 2018

Hey @greno4ka,

Thanks a lot for the PR. It looks good to me. I'll try it out tonight.

@mpereira mpereira merged commit 5fb60cd into mpereira:master May 7, 2018
@mpereira
Copy link
Owner

mpereira commented May 7, 2018

Hello @greno4ka,

Thanks again for submitting this PR. I just merged your changes and pushed a small commit on top: c26a6f4

Let me know if it looks good to you?

Sorry for the delay!

@greno4ka
Copy link
Contributor Author

greno4ka commented May 7, 2018

Yes, if it works, that looks better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants