-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect user-set compiler and linker flags #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good idea! For example, I want to compile your program on my Android phone, using clang.
Please, merge this PR to your project!
b0457b4
to
b792ce8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC ?= gcc
seems to not set the CC
variable if the CC
environment variable is unset in the shell.
Should this be handled with make conditional expressions instead?
cc @greno4ka |
No, it does. It may be affected by the system rules though which may set other default values.
|
I think @AMDmi3 is right. I saw many opensource projects, where is used "?=". I vote for merging this commit. How else can I help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AMDmi3!
No description provided.