Cards are mixed up

[vaporup]

Tested on Debian Bullseye

[greno4ka]

Please, write steps of reproducing this bug.

[dther]

Came here to say I have the same issue, cards are all jumbled. I believe this is due to an update to the ncurses library, but I'm not certain.

• System: Arch Linux
• Started occurring a few months ago, after system upgrade
• Occurs on both st and tty, inside and outside of tmux.
• Bug occurs most of the time, randomly, I place card on top of another card on the tableau.

[mpereira]

Hi @vaporup, @dther,

Thanks for the report. Would you be able to share your current ncurses library version? How did you install tty-solitaire? Have you tried re-installing from source?

[vaporup]

Yes, built from source on Debian Bullseye.

lsb_release -a

No LSB modules are available.
Distributor ID:	Debian
Description:	Debian GNU/Linux bullseye/sid
Release:	testing
Codename:	bullseye

dpkg -l | grep -i libncurses

ii  libncurses-dev:amd64                  6.1+20191019-1  
ii  libncurses5:amd64                     6.1+20191019-1  
ii  libncurses5-dev:amd64                 6.1+20191019-1  
ii  libncurses6:amd64                     6.1+20191019-1  
ii  libncursesw5:amd64                    6.1+20191019-1  
ii  libncursesw5-dev:amd64                6.1+20191019-1  
ii  libncursesw6:amd64                    6.1+20191019-1  

tty-solitaire-1.1.0 $ ldd ./ttysolitaire

linux-vdso.so.1 (0x00007ffd0b69b000)
libncursesw.so.6 => /lib/x86_64-linux-gnu/libncursesw.so.6 (0x00007fcdb7147000)
libtinfo.so.6 => /lib/x86_64-linux-gnu/libtinfo.so.6 (0x00007fcdb7118000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fcdb6f58000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fcdb6f53000)
/lib64/ld-linux-x86-64.so.2 (0x00007fcdb71a9000)

ls -al /lib/x86_64-linux-gnu/libncursesw.so.6

/lib/x86_64-linux-gnu/libncursesw.so.6 -> libncursesw.so.6.1

[dther]

On Arch, downgrading to ncurses 6.1-7 via
pacman -U /var/cache/pacman/pkg/ncurses-6.1-7-x86_64.pkg.tar.xz
completely fixes the issue. The current version of ncurses on the Arch Repos is 6.2-1.

I've tried this both on the version on the official repository, as well as building from source via

git clone https://github.com/mpereira/tty-solitaire.git
cd tty-solitaire
make ttysolitaire
./ttysolitaire

EDIT 20/03: The current version of ncurses on the arch repo was, and still is, 6.2-1. Typo.

[mpereira]

If anyone's up for taking a look into this, please let me know how I can help. I'm currently busy with some life stuff and won't be able to look into it myself until at least the end of the month.

[dther]

I have some C experience, so I'm taking a crack at finding a fix. I have noticed the following:

• Placing black cards on red cards causes the symbols to appear immediately. See edit.
• The suit is always drawn as though the length of the value is only one character. This means that a rank of "10" will cause the 10 to overwrite the suit.
• The overdrawn red symbols move along with the card they're "supposed" to be on. This is consistent when the cards are "picked up" from the tableau.
• The jumbled, overdrawn black symbols disappear or reappear based on whether the card is selected for movement. When the stack of cards is "picked up", they disappear until the stack is placed back on the tableau.

I might try downgrading ncurses again for further testing.

EDIT: The overdrawn black symbols don't appear until picking up the stack at least once.

[mpereira]

This was fixed by #41, and released on tty-solitaire 1.2.0.

@vaporup please let us know if you get a chance to test it out on Debian.

[vaporup]

Works great. Just played through until "You won" without any problems

[mpereira]

Sweet!