Repository navigation
ci: Gate Test Suite on coverage and let fork PRs pass it - #145
Merged
Merged
Conversation
Test Suite, the required check, didn't wait for Coverage Analysis, so a PR under the 60% threshold could still merge; the retired suite-gate job enforced it. It now needs the coverage job and fails with it. Fork PRs get a read-only token, so publishing the test report failed inside the required job and blocked them even with passing tests. The publish step now skips forks, as it already did Dependabot; the status step still fails the job on a failed test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The aggregate check now correctly propagates coverage failures without blocking fork test runs.
Review effort: Balanced
Findings: None
What changed in this PR
Ensures the required Test Suite check enforces coverage while allowing fork PRs to complete successfully.
Changes:
- Adds the coverage job to the aggregate gate and summary.
- Skips test-result publishing for fork and Dependabot PRs.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Enforces coverage gating and handles read-only fork tokens. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Test Results Summary449 tests 449 ✅ 16s ⏱️ Results for commit 43982a8. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 85.13% 85.13%
=======================================
Files 77 77
Lines 1561 1561
Branches 143 143
=======================================
Hits 1329 1329
Misses 189 189
Partials 43 43 |
mpaulosky
enabled auto-merge (squash)
September 29, 2026 19:05
mpaulosky
added a commit
that referenced
this pull request
Sep 29, 2026
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two regressions that Copilot's review of #140 found in the new
ci.yml:Test Suite, the required check, didn't wait forCoverage Analysis, so a PR under 60% coverage could merge. The retiredsuite-gatejob enforced it.Test Suitenow needscoverageand fails when it fails or is cancelled. The coverage result also appears in the job summary.GITHUB_TOKEN, so the test-report publish step failed inside the required job. It now skips forks, as it already skipped Dependabot. The status step still fails the job on any failed test.The other #140 findings are tracked in #144 (release ordering, pre-commit staging, per-project rebuilds) and in the upcoming agent-guidance PR (MD041 vs. the H2 convention).
Validation
scripts/gate.sh: lint, build and all test projects pass🤖 Generated with Claude Code