Skip to content

fix/add new custom field mapping #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 19, 2025
Merged

fix/add new custom field mapping #49

merged 8 commits into from
May 19, 2025

Conversation

gh-mmurph
Copy link
Contributor

@gh-mmurph gh-mmurph commented May 12, 2025 •
edited
Loading

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Added support for parsing and handling custom field mappings to Google's "dc_custom_params" whenever the attributes are present
  • I noticed almost none of the existing tests here worked (for me) so I did larger refactors to the unit test suite and end to end settings - consent tests in particular didn't seem to work so feel free to give those extra scrutiny as I mostly tinkered with them until they started working for me

Testing Plan

  • Was this tested locally? If not, explain why.
  • Yes, tested via Unit tests and testEndtoEnd tests
  • Verified that attribute I mapped "test_attribute" and value "123", saw it's value sent to GTM as "match_id"

Screenshot 2025-05-12 at 3 13 08 PM

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@gh-mmurph gh-mmurph marked this pull request as ready for review May 12, 2025 19:17
rmi22186
rmi22186 approved these changes May 19, 2025
View reviewed changes
Copy link
Collaborator

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM! thanks @gh-mmurph

@rmi22186
Copy link
Collaborator

reviewed and tested locally with @gh-mmurph live. merging now

@rmi22186 rmi22186 merged commit 992b406 into mparticle-integrations:development May 19, 2025
2 checks passed
rmi22186 pushed a commit that referenced this pull request May 19, 2025
@gh-mmurph @rmi22186
feat: Add custom field mapping (#49)
e30b968
rmi22186 pushed a commit that referenced this pull request May 19, 2025
@gh-mmurph @rmi22186
feat: Add custom field mapping (#49)
d7da081
github-actions bot pushed a commit that referenced this pull request May 19, 2025
@mparticle-automation
chore(release): 2.2.0 [skip ci]
ac51f20 
# [2.2.0](v2.1.3...v2.2.0) (2025-05-19)

### Features

* Add custom field mapping ([#49](#49)) ([d7da081](d7da081))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

+1 more reviewer

@ganesh17m ganesh17m ganesh17m approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gh-mmurph @rmi22186 @ganesh17m