Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix func names to fix build of gonstructor #8

Closed
wants to merge 1 commit into from

Conversation

kovetskiy
Copy link
Contributor

Currently gonstructor has compilation errors:

# github.com/moznion/gonstructor/internal/constructor
../../internal/constructor/all_args_constructor_generator.go:26:32: funcSignature.AddFuncParameters undefined (type *generator.FuncSignature has no field or method AddFuncParameters)
../../internal/constructor/builder_constructor_generator.go:44:56: generator.NewFuncSignature(strcase.ToCamel(field.FieldName)).AddFuncParameters undefined (type *generator.FuncSignature has no field or method AddFuncParameters)

and after fixing it you could get

# github.com/moznion/gonstructor/cmd/gonstructor
cmd/gonstructor/gonstructor.go:102:23: rootStmt.EnableGoimports undefined (type *generator.Root has no field or method EnableGoimports)

@kovetskiy
Copy link
Contributor Author

@moznion Hi! Could you please take a look at the PR because currently gonstructor's master branch doesn't work 😢

@seletskiy
Copy link

@moznion hi, I have similar problem.

@kovetskiy
Copy link
Contributor Author

@moznion ping

moznion added a commit to moznion/gonstructor that referenced this pull request Jan 19, 2020
@moznion
Copy link
Owner

moznion commented Jan 19, 2020

I'm sorry for the late reply and I appreciate your patience.

This issue because gonstructor uses older gowrtr (i.e. v1.0.0) so the method signatures were not compatible with the latest ones.
gonstructor's code has just followed the latest gowrtr so it would be able to compile certainly (ref: moznion/gonstructor@f712621).

(And, go vendoring mechanism doesn't allow to use v2 as a version specifier; therefore, I've re-versioned those that have v2 version to v1.x.x )

@kovetskiy Once you confirmed the problem has been solved, could you please close this issue?

@kovetskiy kovetskiy closed this Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants