Skip to content

fix: firefoxPreview option should be set to mv3 only when explicitly requested #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2022
Merged

fix: firefoxPreview option should be set to mv3 only when explicitly requested #2454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/program.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,10 @@ export class Program {
throw new UsageError('Not enough arguments following: start-url');
}

if (Array.isArray(argv.firefoxPreview) && !argv.firefoxPreview.length) {
argv.firefoxPreview = ['mv3'];
}

return argv;
}

Expand Down Expand Up @@ -692,9 +696,9 @@ Example: $0 --help run.
type: 'array',
},
'firefox-preview': {
describe: 'Turn on developer preview features in Firefox',
describe: 'Turn on developer preview features in Firefox' +
' (defaults to "mv3")',
demandOption: false,
default: ['mv3'],
type: 'array',
},
// Firefox for Android CLI options.
Expand Down
12 changes: 12 additions & 0 deletions tests/unit/test.program.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,6 +922,18 @@ describe('program.main', () => {
const {firefoxPreview} = fakeCommands.run.firstCall.args[0];
assert.deepEqual(firefoxPreview, ['mv3']);
});

it('does not set any firefox preview prefs by default', async () => {
const fakeCommands = fake(commands, {
run: () => Promise.resolve(),
});

await execProgram(['run'], {commands: fakeCommands});

const {firefoxPreview} = fakeCommands.run.firstCall.args[0];
assert.deepEqual(firefoxPreview, undefined);
});

});

describe('program.defaultVersionGetter', () => {
Expand Down