Add `web-ext submit` to submit listed add-ons to AMO

[fregante]

Workaround described below ⬇️

Is this a bug or feature request?

Feature request

What is the current behavior?

web-ext sign already successfully submits an extension for review, but then it throws an error.

What is the expected or desired behavior?

I don't need instant signing, so if the submission has been successful there should be a way to make it exit with 0.

Suggestions:

$ web-ext sign --submit-only
$ web-ext submit

Version information (for bug reports)

OS X 10.11.6

node --version && npm --version && web-ext --version

v7.2.0
3.10.9
1.8.1

[kumar303]

The sign command is intended more for people who self-distribute their add-ons. In your case, why not just use the website? https://addons.mozilla.org/en-US/developers/addon/submit/distribution Is it because you need to put new versions in the review queue frequently? Or just because you'd like to automate the submission process?

[fregante]

Automate all the things! 😉 Here people discussed the Chrome Web Store version, but it also applies to AMO sindresorhus/project-ideas#66

[kumar303]

Yeah, using web-ext to automatically put a new version in the AMO review queue seems like it could be useful to support automatic deployment (from a git tag or whatever).

I think it would make sense as a new command, such as what you recommended: web-ext submit or web-ext submit-to-amo (to be explicit, maybe).

The good news is that sign-addon already wraps up the signing API pretty well. The bad news is that the API doesn't support submission of listed add-ons in a straightforward way. Using the signing API to submit a listed add-on would be a hack and I'm not sure that it would be so dependable against future API changes. The fact that it works now at all is just by side effect.

We decided to log an informative message about it in web-ext sign but we also let it throw an error to discourage usage. I guess that's a little weird though, heh.

[FranciscoG]

100% this!

I just setup some tasks to automate submitting my extension to the Chrome web store and now I'm working on Firefox (first time ever messing with Firefox Add-ons, so happy about WebExtensions). Looking through the Firefox documentation it wasn't clear to me at all that I could automate sending updates to AMO for an existing add-on... not for self-hosting/self-signing. I even just asked a question on stackoverflow about this.

[kumar303]

Even if we added a web-ext submit command, it would not be fully possible to automate submission. The addons.mozilla.org site always requires an editor to review the extension code which is different from the Chrome Store (I believe).

[fregante]

Understood. The current web-ext sign workflow is fine and it's enough for me already. The only issue is the error exit code.

It's still better than packaging it up, opening the browser, visiting AMO, uploading it, etc manually.

[FranciscoG]

agreed . I just want Travis to be able to build and send it off my extension to each respective store. I understand that there's a review process.

I guess for now I'll deal with the error.

@bfred-it are you requiring web-ext from a module? is that possible? or you using child process? Any issues installing web-ext a local dev dependency?

[fregante]

@FranciscoG I'm not, I plan on using it via npm scripts like I'm doing with chrome-webstore-upload-cli on travis

[fregante]

Workaround

I published a 11-lines, temporary web-ext wrapper that filters out the error:

npm install --global web-ext-submit
web-ext-submit

Meant to be used on Travis or GitHub Actions.

https://github.com/fregante/web-ext-submit

Alternative

Or use https://github.com/LinusU/wext-shipit