Get external errors working for Swift and Python #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2025
Does not work with Kotlin - see mozilla#2392
mhammond
force-pushed
the
push-tutvkrzuvoks
branch
from
9642a98 to
846d762
Compare
mhammond
commented
Jan 9, 2025
| @@ -576,6 +576,15 @@ impl<T: AsType> AsCodeType for T { | |||
| } | |||
| } | |||
|
|
|||
| // A work around for #2392 - we can't handle functions with external errors. | |||
| fn can_render_callable(callable: &dyn Callable, ci: &ComponentInterface) -> bool { | |||
There was a problem hiding this comment.
@bendk this is what I was thinking re our discussions around tests etc - at some point it seems reasonable for binding generators to simply decline to render things they can't handle - eg, I could imagine a new bindgen might start by declining to implement functions which try and use anything other than primitive types as they are starting out etc.
mhammond
changed the title
bendk
approved these changes
Jan 10, 2025
I don't think so, no. I'm actually becoming convinced it's really not at all trivial to fix given how our "companion" objects and external rust buffers are setup (but I could be very wrong about that) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost - Swift+Python work. Kotlin doesn't work (#2392), however it works around failing simply by declining to render any functions with external errors, which seems reasonable for now.