Depend on the patched oneshot version (#1736)

[bendk]

After trying a couple times to vendor our code into moz-central using a patch in Cargo.toml, I think this is a better solution. I'm hoping to merge this into the 0.25.x branch, release 0.25.3, and use that.

This will test our release strategy a bit. We should be able to upgrade moz-central to using 0.25.3 without changing Glean or app-services.

[badboy]

you cannot release uniffi_core to crates.io with a git dependency.
One way would be to publish a bendk-oneshot crate and depend on that.

[bendk]

you cannot release uniffi_core to crates.io with a git dependency.
One way would be to publish a bendk-oneshot crate and depend on that.

TIL. I named the crate oneshot-uniffi and updated Cargo.toml.

[mhammond]

What changes have we made to oneshot? Have we tried upstreaming them (eg, via a feature)? Someone will have to do a fair bit of sleuthing to even find the sources to the forked version, so this situation doesn't seem ideal longer term - I'm wondering what we are doing to prevent it being a long term thing?

[bendk]

Here's the change: bendk/oneshot@a95e9ed

The issue is that that the loom dependency is only used for the loom target, but that's still an issue for moz-central because the vendoring process brings in all dependencies for all possible target/feature combinations.

It's not a great situation, but I can't think of a better solution. Maybe the long-term solution is to wait for cargo vendor to add support for disabling certain targets (something like rust-lang/cargo#7058)