Add support for train-vocab
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I discovered that these artifacts are not actually published right now. The pipeline script wants a prefix, not a directory.
As with the previous `merge-corpus`, this is a pretty straightforward step. It's solely downstream of `merge-corpus`, and takes one parameter from the action input.
gabrielBusta
approved these changes
May 23, 2023
| # 2) input files | ||
| - >- | ||
| export BIN=$MOZ_FETCHES_DIR && | ||
| $VCS_PATH/pipeline/clean/merge-corpus.sh | ||
| artifacts | ||
| artifacts/corpus |
There was a problem hiding this comment.
That's a prefix of the artifacts from the merge-corpus step. (The spm-train.sh scripts wants a prefix which it appends some suffixes too.)
| $VCS_PATH/pipeline/train/spm-vocab.sh | ||
| fetches/corpus.{src_locale}.zst | ||
| fetches/corpus.{trg_locale}.zst | ||
| artifacts/vocab.spm |
There was a problem hiding this comment.
Why not artifacts/<something>/vocab.spm?
There was a problem hiding this comment.
We could do that, yeah, although it might be a bit annoying for downstream steps (we'd end up with an extra directory in the artifact path). I'm good either way.
There was a problem hiding this comment.
nah, I see the prefix above is not a directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much more straightforward pipeline step addition - mostly just the usual pipeline script tweaks and a new kind. The only notable parts are:
merge-corpusartifacts (whoops)My latest test run in staging can be found at https://firefox-ci-tc.services.mozilla.com/tasks/FxbqwlALQ0uIQaNUkKOL1w.