Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove heavy users #435

Merged
merged 3 commits into from
Jun 8, 2018
Merged

Remove heavy users #435

merged 3 commits into from
Jun 8, 2018

Conversation

fbertsch
Copy link
Contributor

@fbertsch fbertsch commented Jun 4, 2018

Let me know if you see something I missed.

@fbertsch fbertsch requested a review from mreid-moz June 4, 2018 16:52
@codecov-io
Copy link

codecov-io commented Jun 4, 2018

Codecov Report

Merging #435 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #435      +/-   ##
=========================================
+ Coverage   69.62%   69.9%   +0.28%     
=========================================
  Files          48      45       -3     
  Lines        4141    4007     -134     
  Branches      146     135      -11     
=========================================
- Hits         2883    2801      -82     
+ Misses       1258    1206      -52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31912c4...b401b4b. Read the comment docs.

@jklukas
Copy link
Contributor

jklukas commented Jun 7, 2018

I just hit "update branch". This should be able to pass tests again with #436 merged.

Copy link
Contributor

@mreid-moz mreid-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It seems a shame to delete the partitioner code, but since it isn't used by anything else, I think it's the right call.

@fbertsch fbertsch merged commit 34b01a2 into mozilla:master Jun 8, 2018
@fbertsch
Copy link
Contributor Author

fbertsch commented Jun 8, 2018

@mreid-moz they're in the git log, we can always dust 'em off if we want them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants