Use built-in URL

[tromey]

source-map implements its own URL parsing, but it seems to me that it would be better to just use the built-in URL.

[tromey]

For node we need require("url") but for the browser we don't want that.

[tromey]

But maybe we could work around that in devtools-source-map.

[tromey]

We'll also need to work around it for the bundle that's put in devtools/shared/sourcemap. Maybe we ought to make a new webpack config for that.

[tromey]

One problem the current approach causes is that library users can't pass a data: URL as the source map URL to SourceMapConsumer, because the current code can't parse a data: URL. (Though, maybe this is minor, because passing a data: URL there is useless anyway...)

[tromey]

This problem came up again here: https://bugzilla.mozilla.org/show_bug.cgi?id=1451274

I wrote a quick patch to change this but I am not completely sure it is correct. E.g., it regresses this test:

  assert.equal(libUtil.join('http://foo.org/a//', '//b'), 'http://b');

and this one:

  assert.equal(libUtil.join('http://www.example.com', '//foo.org/bar'), 'http://foo.org/bar');

I can't recall offhand if these are part of the spec or not, will have to check.

[edmorley]

Hi! Is there anything we can do to help move this forwards?

Several Mozilla web teams use webpack based workflows, so are potentially affected by sourcemap issues that come up (eg webpack-contrib/style-loader#303). It would be good to try and keep our own employees using Firefox for web development :-)

[tromey]

Hi! Is there anything we can do to help move this forwards?

Sure - take over the patch here: https://github.com/tromey/source-map/tree/use-real-url
The main thing is to investigate the issues pointed out above (#275 (comment)).

For the webpack-contrib issue you linked to, a further part would be to add tests for blob URLs.

If you really want to do all this I can also tell you how to get everything landed. I'm not working on devtools any more, which is why I'm not doing this... but another option would be to contact someone in devtools to see if anyone there can do it.

[jasonLaster]

This bug is a priority.

If we can land this branch master...tromey:use-real-url, here I'd be happy to cut a new release and land it in MC.

Here is a link to the devtools-source-maps package. @tromey we moved it into the debugger.html repo so it can be updated when the debugger updates.

[heyflo]

I tried for some hours to implement correct sourcemaps for my dev environment with webpack and I just could not solve it. Just to find out it's a known issue and it's working perfectly on Chrome. I'm using the last build on Firefox Dev Edition(62.0b3) and the style loader on webpack 4 (4.12.1)

Here is what I get :

[jigz]

I'm having issues too

[jasonLaster]

Hey @heyflo @JigzPalillo I'd be happy to take a look next week when I'm back. Ping me in our slack.

👋 https://devtools-html-slack.herokuapp.com/

[devinrm]

Hi, is there any movement on this yet? It's a bummer not to be able to use FF for development. Thanks for all your hard work!