-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Xcode CI / Docs #2266
Simplify Xcode CI / Docs #2266
Conversation
Meh, just as we got the #2257 merged, some Xcode warning exposes that it supports |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2266 +/- ##
==========================================
+ Coverage 30.91% 40.62% +9.71%
==========================================
Files 53 54 +1
Lines 20112 20734 +622
Branches 9755 9637 -118
==========================================
+ Hits 6217 8423 +2206
- Misses 7922 8148 +226
+ Partials 5973 4163 -1810 ☔ View full report in Codecov by Sentry. |
Aha, but actually now it enables the response file use, so that needs to be disabled, I was a bit hasty on this PR, it needs a bit more work to be correct. |
3094640
to
b428d49
Compare
Alright, when using I think it is much better like this. |
I happened to stumble upon the `C_COMPILER_LAUNCHER` Xcode attribute, which fits the bill perfectly, so use that instead.
Just a friendly poke, was there any concerns here? |
nope, thanks for the ping :) |
I happened to stumble upon the
C_COMPILER_LAUNCHER
Xcode attribute,which fits the bill perfectly, so use that instead.