Skip to content

updates the is_already_at version to match update package script #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2021
Merged

updates the is_already_at version to match update package script #24

merged 1 commit into from
Nov 26, 2021

Conversation

tarikeshaq
Copy link
Contributor

We made the version of AS clearer in #23, this PR changes the is_already_updated.py script to read the same line (so it doesn't always keep trying to update AS when it's already updated)

@tarikeshaq tarikeshaq requested a review from a team November 25, 2021 18:55
@data-sync-user data-sync-user mentioned this pull request Nov 25, 2021
Closed
mhammond
mhammond approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A regex is probably more idiomatic (and I guess would also have been more idiomatic in the first version too), but this looks like it will work :)

@tarikeshaq tarikeshaq merged commit a9927c8 into main Nov 26, 2021
@tarikeshaq tarikeshaq deleted the update-script branch November 26, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhammond mhammond mhammond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarikeshaq @mhammond