Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tree-sitter and each grammars to v0.19 #552

Merged
merged 18 commits into from
Mar 26, 2021
Merged

Update tree-sitter and each grammars to v0.19 #552

merged 18 commits into from
Mar 26, 2021

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Mar 16, 2021 •
edited
Loading

This PR updates the tree-sitter crate and each rust-code-analysis grammar to v0.19

Ticks an item when there are no significant differences in the grammar

  • tree-sitter-mozcpp
  • tree-sitter-mozjs
  • tree-sitter-ccomment
  • tree-sitter-preproc
  • tree-sitter-rust
  • tree-sitter-python
  • tree-sitter-javascript
  • tree-sitter-typescript

@Luni-4 Luni-4 marked this pull request as draft March 16, 2021 13:04
@codecov-io
Copy link

codecov-io commented Mar 16, 2021 •
edited
Loading

Codecov Report

Merging #552 (eea741a) into master (9cb72f1) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   25.97%   25.61%   -0.37%     
==========================================
  Files          45       45              
  Lines        5666     5746      +80     
  Branches      851      851              
==========================================
  Hits         1472     1472              
- Misses       3660     3740      +80     
  Partials      534      534
Impacted Files Coverage Δ
src/checker.rs 36.36% <ø> (ø)
src/languages/language_javascript.rs 0.00% <0.00%> (ø)
src/languages/language_mozjs.rs 0.00% <0.00%> (ø)
src/languages/language_python.rs 0.00% <0.00%> (ø)
src/languages/language_rust.rs 0.00% <0.00%> (ø)
src/languages/language_tsx.rs 0.00% <0.00%> (ø)
src/languages/language_typescript.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cb72f1...eea741a. Read the comment docs.

@Luni-4 Luni-4 force-pushed the update-tree-sitter branch 8 times, most recently from 8ae91ca to 596a928 Compare March 19, 2021 09:11
This was referenced Mar 19, 2021
Open
Open
Open
Closed
Open
This was referenced Mar 19, 2021
Closed
Open
Open
Closed
@Luni-4 Luni-4 force-pushed the update-tree-sitter branch 3 times, most recently from fef341f to 21b6fc6 Compare March 24, 2021 14:19
Luni-4
Luni-4 commented Mar 24, 2021
View reviewed changes
src/metrics/loc.rs
[
(sloc, 5, usize), // The number of lines is 5
(ploc, 5, usize), // The number of code lines is 5
(lloc, 7, usize), // The number of statements is 7
Copy link
Collaborator Author

@Luni-4 Luni-4 Mar 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marco-c I don't know if I counted the number of statements correctly. Could you re-check, please?

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Mar 26, 2021

@marco-c

This PR is ready to be reviewed. I covered all possible cases extracted from minimal tests and notified upstream when there were parse errors.

@Luni-4 Luni-4 marked this pull request as ready for review March 26, 2021 08:37
@marco-c
Copy link
Collaborator

marco-c commented Mar 26, 2021

This PR is ready to be reviewed. I covered all possible cases extracted from minimal tests and notified upstream when there were parse errors.

Can you list here in a comment all the issues you filed upstream? So we have a way to track them.

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Mar 26, 2021 •
edited
Loading

List of regressions that have been found for tree-sitter v0.19

marco-c
marco-c reviewed Mar 26, 2021
View reviewed changes
src/checker.rs
@@ -212,7 +212,17 @@ impl Checker for TypescriptCode {
ClassDeclaration,
ArrowFunction
);
mk_else_if!(IfStatement);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems for both Rust and TypeScript you made the same change. What if we changed the mk_else_if! macro instead? Is there any language which still needs the previous implementation?

Copy link
Collaborator Author

@Luni-4 Luni-4 Mar 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaScript, Python, Mozcpp need the previous implementation

@Luni-4 Luni-4 merged commit 51a4cb4 into mozilla:master Mar 26, 2021
@Luni-4 Luni-4 deleted the update-tree-sitter branch March 26, 2021 18:53
@Luni-4 Luni-4 mentioned this pull request Mar 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-c marco-c marco-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Luni-4 @codecov-io @marco-c