Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify tests for more deterministic behavior #1081

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Modify tests for more deterministic behavior #1081

merged 2 commits into from
Jan 8, 2024

Conversation

michaelvanstraten
Copy link
Contributor

No description provided.

@Luni-4
Copy link
Collaborator

Luni-4 commented Jan 7, 2024

@michaelvanstraten

Now that #1078 has been merged, we can fix CI using this PR. Let's use yaml comparisons and not json due to the advice written here. We can also integrate the missing features present in #1080

We need to update the snapshots accordingly in the rust-code-analysis-output repository

@michaelvanstraten
Copy link
Contributor Author

Let's use yaml comparisons

Already implemented, for the same reason.

We can also integrate the missing features present in #1080

Do you mean the switch to std::collections::Hashmap, the sorting of maps or both?

@Luni-4
Copy link
Collaborator

Luni-4 commented Jan 8, 2024

We can just sort out the maps in this PR, thanks for the catch!

@michaelvanstraten michaelvanstraten changed the title Modified tests to use insta's assert_yaml_snapshot Modify tests for more deterministic behavior Jan 8, 2024
@michaelvanstraten
Copy link
Contributor Author

@Luni-4, tests pass except for the three sitter checks, can you check it out?

Copy link
Collaborator

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! For what concerns tree-sitter checks, it seems they are running because of some changed values. We can leave them as-is for now

.gitmodules Outdated Show resolved Hide resolved
Copy link
Collaborator

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @michaelvanstraten!

@marco-c In my opinion we can merge this PR and open an issue to find the possible issues with grammar checkers

@marco-c marco-c merged commit 64e146f into mozilla:master Jan 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants