Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify getter code #1019

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Simplify getter code #1019

merged 1 commit into from
Apr 5, 2023

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Mar 31, 2023

This PR simplifies getter code simplifying code and removing some redundant lines

@Luni-4 Luni-4 requested a review from marco-c March 31, 2023 11:22
src/getter.rs Show resolved Hide resolved
@Luni-4 Luni-4 force-pushed the simplify-getter branch from cf620d0 to 97189d2 Compare April 4, 2023 07:33
@Luni-4 Luni-4 requested a review from marco-c April 4, 2023 07:34
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06 ⚠️

Comparison is base (9ce42a2) 67.91% compared to head (97189d2) 67.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
- Coverage   67.91%   67.86%   -0.06%     
==========================================
  Files          61       61              
  Lines       12345    12325      -20     
==========================================
- Hits         8384     8364      -20     
  Misses       3961     3961              
Impacted Files Coverage Δ
src/getter.rs 82.14% <100.00%> (-1.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marco-c marco-c merged commit e3d5740 into master Apr 5, 2023
@marco-c marco-c deleted the simplify-getter branch April 5, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants