Add metrics for Rust code

mozilla · Nov 20, 2019 · 8b65075 · 8b65075
1 parent 00d4307
commit 8b65075
Show file tree

Hide file tree

Showing 7 changed files with 81 additions and 7 deletions.
diff --git a/src/checker.rs b/src/checker.rs
@@ -277,6 +277,13 @@ impl Checker for RustCode {
 
     mk_checker!(is_string, StringLiteral, RawStringLiteral);
     mk_checker!(is_call, CallExpression);
-    mk_checker!(is_func, FunctionItem);
-    mk_checker!(is_func_space, SourceFile, FunctionItem, ImplItem);
+    mk_checker!(is_func, FunctionItem, ClosureExpression);
+    mk_checker!(
+        is_func_space,
+        SourceFile,
+        FunctionItem,
+        ImplItem,
+        TraitItem,
+        ClosureExpression
+    );
 }
diff --git a/src/cyclomatic.rs b/src/cyclomatic.rs
@@ -117,6 +117,19 @@ impl Cyclomatic for TsxCode {
     }
 }
 
+impl Cyclomatic for RustCode {
+    fn compute(node: &Node, stats: &mut Stats) {
+        use Rust::*;
+
+        match node.kind_id().into() {
+            If | For | While | Loop | MatchArm | MatchArm2 | QMARK | AMPAMP | PIPEPIPE => {
+                stats.cyclomatic += 1.;
+            }
+            _ => {}
+        }
+    }
+}
+
 impl Cyclomatic for PreprocCode {}
 impl Cyclomatic for CcommentCode {}
 impl Cyclomatic for CCode {}
@@ -126,4 +139,3 @@ impl Cyclomatic for JavaCode {}
 impl Cyclomatic for GoCode {}
 impl Cyclomatic for CssCode {}
 impl Cyclomatic for HtmlCode {}
-impl Cyclomatic for RustCode {}
diff --git a/src/dump.rs b/src/dump.rs
@@ -57,7 +57,7 @@ fn dump_tree_helper(
         write!(&mut stdout, "{}{}", prefix, pref).unwrap();
 
         color!(stdout, Yellow, true);
-        write!(&mut stdout, "{{{}}} ", node.kind()).unwrap();
+        write!(&mut stdout, "{{{}:{}}} ", node.kind(), node.kind_id()).unwrap();
 
         color!(stdout, White);
         write!(&mut stdout, "from ").unwrap();

diff --git a/src/enums.rs b/src/enums.rs
@@ -6,6 +6,8 @@ pub enum NodeKind {
     Function,
     Class,
     Struct,
+    Trait,
+    Impl,
     Unit,
 }
 
@@ -16,6 +18,8 @@ impl fmt::Display for NodeKind {
             NodeKind::Function => "function",
             NodeKind::Class => "class",
             NodeKind::Struct => "struct",
+            NodeKind::Trait => "trait",
+            NodeKind::Impl => "impl",
             NodeKind::Unit => "unit",
         };
         write!(f, "{}", s)

diff --git a/src/getter.rs b/src/getter.rs
@@ -99,6 +99,21 @@ impl Getter for TsxCode {
     }
 }
 
+impl Getter for RustCode {
+    fn get_kind(node: &Node) -> NodeKind {
+        use Rust::*;
+
+        let typ = node.kind_id();
+        match typ.into() {
+            FunctionItem | ClosureExpression => NodeKind::Function,
+            TraitItem => NodeKind::Trait,
+            ImplItem => NodeKind::Impl,
+            SourceFile => NodeKind::Unit,
+            _ => NodeKind::Unknown,
+        }
+    }
+}
+
 impl Getter for PreprocCode {}
 impl Getter for CcommentCode {}
 impl Getter for CCode {}
@@ -108,4 +123,3 @@ impl Getter for JavaCode {}
 impl Getter for GoCode {}
 impl Getter for CssCode {}
 impl Getter for HtmlCode {}
-impl Getter for RustCode {}
diff --git a/src/halstead.rs b/src/halstead.rs
@@ -257,6 +257,29 @@ impl Halstead for TsxCode {
     }
 }
 
+impl Halstead for RustCode {
+    fn compute<'a>(node: &Node<'a>, code: &'a [u8], stats: &mut Stats<'a>) {
+        use Rust::*;
+
+        let id = node.kind_id();
+        match id.into() {
+            LPAREN | LBRACE | LBRACK | EQGT | PLUS | STAR | Async | Await | Continue | For | If
+            | Let | Loop | Match | Return | Unsafe | While | BANG | EQ | COMMA | DASHGT | QMARK
+            | LT | GT | AMP | MutableSpecifier | DOTDOT | DOTDOTEQ | DASH | AMPAMP | PIPEPIPE
+            | PIPE | CARET | EQEQ | BANGEQ | LTEQ | GTEQ | LTLT | GTGT | SLASH | PERCENT
+            | PLUSEQ | DASHEQ | STAREQ | SLASHEQ | PERCENTEQ | AMPEQ | PIPEEQ | CARETEQ
+            | LTLTEQ | GTGTEQ | Move | DOT => {
+                *stats.operators.entry(id).or_insert(0) += 1;
+            }
+            Identifier | StringLiteral | RawStringLiteral | IntegerLiteral | FloatLiteral
+            | BooleanLiteral | Zelf | CharLiteral | UNDERSCORE => {
+                *stats.operands.entry(get_id(node, code)).or_insert(0) += 1;
+            }
+            _ => {}
+        }
+    }
+}
+
 impl Halstead for PreprocCode {}
 impl Halstead for CcommentCode {}
 impl Halstead for CCode {}
@@ -266,4 +289,3 @@ impl Halstead for JavaCode {}
 impl Halstead for GoCode {}
 impl Halstead for CssCode {}
 impl Halstead for HtmlCode {}
-impl Halstead for RustCode {}
diff --git a/src/sloc.rs b/src/sloc.rs
@@ -145,6 +145,22 @@ impl SourceLoc for TsxCode {
     }
 }
 
+impl SourceLoc for RustCode {
+    fn compute(node: &Node, _code: &[u8], stats: &mut Stats, is_func_space: bool) {
+        use Rust::*;
+
+        let start = init(node, stats, is_func_space);
+
+        match node.kind_id().into() {
+            LineComment | BlockComment | StringLiteral | RawStringLiteral | ExpressionStatement
+            | Block => {}
+            _ => {
+                stats.lines.insert(start);
+            }
+        }
+    }
+}
+
 impl SourceLoc for PreprocCode {}
 impl SourceLoc for CcommentCode {}
 impl SourceLoc for CCode {}
@@ -154,4 +170,3 @@ impl SourceLoc for JavaCode {}
 impl SourceLoc for GoCode {}
 impl SourceLoc for CssCode {}
 impl SourceLoc for HtmlCode {}
-impl SourceLoc for RustCode {}