Turn off the most time-consuming Date tests in MozillaSuiteTest #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are tests that iterate through all the days in a year and test date constructing and parsing. I think that at this point, between the test262 tests and the fact that date parsing in Java seems well-tested, we don't need these tests. These tests are incredibly-time consuming, especially in interpreted mode -- one of them took 84 seconds on my machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are tests that iterate through all the days in a year and test date constructing and parsing. I think that at this point, between the test262 tests and the fact that date parsing in Java seems well-tested, we don't need these tests.
These tests are incredibly-time consuming, especially in interpreted mode -- one of them took 84 seconds on my machine.
This is a more focused version of a previous PR. I am also interested in exploring whether we really need to test three optimization levels, and whether we need all of the Mozilla suite, but this is a "low-hanging fruit."