Fix flaky ShellTimerTest

The nested timer test was depending on how long it took for the tests to run, which is never a good thing for a timer-related test.
mozilla · Oct 4, 2024 · 5b9ba19 · 5b9ba19
1 parent 3d7b17b
commit 5b9ba19
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/tests/src/test/java/org/mozilla/javascript/tests/ShellTimerTest.java b/tests/src/test/java/org/mozilla/javascript/tests/ShellTimerTest.java
@@ -125,9 +125,14 @@ public void nestedTimers() throws InterruptedException {
         runTest(
                 "load('testsrc/assert.js');\n"
                         + "let count = 0;\n"
-                        + "setTimeout(() => { assertEquals(0, count++);\n"
-                        + "  setTimeout(() => { assertEquals(2, count++); TestsComplete = true; }, 5);\n"
-                        + "  setTimeout(() => { assertEquals(1, count++); }, 2);\n"
+                        + "setTimeout(() => {\n"
+                        + "  setTimeout(() => {\n"
+                        + "    setTimeout(() => {\n"
+                        + "      assertEquals(2, count++); TestsComplete = true;\n"
+                        + "    });"
+                        + "    assertEquals(1, count++);\n"
+                        + "  }, 2);\n"
+                        + "  assertEquals(0, count++);\n"
                         + "});");
     }