Bug 1347472 - Tests for WordPress blogs, r=Gijs #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanxd
commented
Mar 15, 2017
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "title": "Stack Overflow Jobs Data Shows ReactJS Skills in High Demand, WordPress Market Oversaturated with Developers – WordPress Tavern", | |||
| "byline": null, | |||
There was a problem hiding this comment.
Filed a follow up issue #371 to get the right byline.
|
Hi @gijsk , Could you help review the patch? Thanks. |
gijsk
reviewed
Mar 15, 2017
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "title": "Stack Overflow Jobs Data Shows ReactJS Skills in High Demand, WordPress Market Oversaturated with Developers – WordPress Tavern", | |||
There was a problem hiding this comment.
I thought we'd be trying to get rid of the "WordPress Tavern" bit, too. Why isn't that working? Maybe that wants to be another issue?
There was a problem hiding this comment.
Yes, you're right. Filed the follow-up issue #372.
gijsk
approved these changes
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for WordPress blogs(global rank 40). The test page is https://wptavern.com/stack-overflow-jobs-data-shows-reactjs-skills-in-high-demand-wordpress-market-oversaturated-with-developers.