Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1346155 - Tests for gmw.cn, r=Gijs #365

Merged
merged 1 commit into from
Mar 10, 2017
Merged

Bug 1346155 - Tests for gmw.cn, r=Gijs #365

merged 1 commit into from
Mar 10, 2017

Conversation

evanxd
Copy link
Contributor

@evanxd evanxd commented Mar 10, 2017

Tests for gmw.cn(global rank 89). The test page is http://tech.gmw.cn/2017-03/10/content_23937776.htm.

@evanxd evanxd self-assigned this Mar 10, 2017
@evanxd evanxd mentioned this pull request Mar 10, 2017
Open
evanxd
evanxd commented Mar 10, 2017
View reviewed changes
test/test-pages/gmw/expected-metadata.json
@@ -0,0 +1,7 @@
{
"title": "宇航员在太空中喝酒会怎么样？后果很严重 _探索者 _光明网",
Copy link
Contributor Author

@evanxd evanxd Mar 10, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed a follow up issue #366 to strip "_探索者 _光明网" at end of the title.

@evanxd evanxd requested a review from gijsk March 10, 2017 10:29
@evanxd
Copy link
Contributor Author

evanxd commented Mar 10, 2017

Hi Gijs,

Could you help review the test? Thanks.

@gijsk
Copy link
Contributor

gijsk commented Mar 10, 2017

Looks like this:

　　出品︱网易科学人栏目组 胖胖
　　作者︱春春 [返回光明网首页]
[责任编辑:肖春芳]

should ideally be removed, but there's no real markup to go on?

Also, the empty <ins> element should be removed, but I think we have an issue on file for this already. otherwise this looks fine.

@gijsk gijsk merged commit 630a0b7 into mozilla:master Mar 10, 2017
@evanxd
Copy link
Contributor Author

evanxd commented Mar 13, 2017 

　　出品︱网易科学人栏目组 胖胖
　　作者︱春春 [返回光明网首页]
[责任编辑:肖春芳]

It's hard to say this is a part of the article, or not. I would say we don't need to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gijsk gijsk Awaiting requested review from gijsk

Assignees

@evanxd evanxd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanxd @gijsk