Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add microformats2 class names to heuristics #303

Merged
merged 1 commit into from
Aug 13, 2016
Merged

Add microformats2 class names to heuristics #303

merged 1 commit into from
Aug 13, 2016

Conversation

tigt
Copy link
Contributor

@tigt tigt commented Jul 28, 2016

Microformats updated their old hentry to a newer
h-entry
.

With the number of IndieWeb sites breaking into the
ten-thousands
,
this seems like a fair idea.

Microformats updated their old `hentry` to [a newer
`h-entry`](http://microformats.org/wiki/h-entry).

With the [number of IndieWeb sites breaking into the
ten-thousands](http://tantek.com/2016/190/b1/state-of-indieweb-summit),
this seems like a fair idea.
@gijsk
Copy link
Contributor

gijsk commented Aug 13, 2016

Sorry for the extreme delay, I was on vacation for 2 weeks and this got lost in the noise since my return (most of what I do is in bugzilla, not github...). I promise I'm normally more prompt with giving feedback on PRs. :-\

This looks sane to me, though it would be nice if you had an example page where this is useful that we could use to augment the test set. Can do that in a separate PR / issue though.

@gijsk gijsk merged commit 71aa562 into mozilla:master Aug 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants