Byline information missing from engadget.com pages in Reader View

[avaida]

Affected:

• 38.0b5-build1
• 39.0a2 (2015-04-16)
• 40.0a1 (2015-04-16)

Sample pages:

• http://www.engadget.com/2015/04/16/works-with-google-cardboard-program/
• http://www.engadget.com/2015/04/03/the-best-touchscreen-gloves/

[leplatrem]

From what I understood :

• The byline information is well structured in the page : it's <div class="byline"> within a <header>
• But header belongs to REGEXPS.unlikelyCandidates
• Since unlikely candidates are removed on the first iteration, it never get a chance to be parsed.

We could fix it by adding header into REGEXPS.okMaybeItsACandidate ?

[gijsk]

Making headers into candidates means they will be preserved into the main document which is clearly not what we want. The correct thing to do would be looking for a byline before removing stuff. This is covered by #45 .