-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postinstallation (and thus DevTools) broken by Brotli compression of omni.ja contents #132
Comments
Still no way around this issue? |
This reverts commit e11d9f4.
Brotli compression has been backed out of Firefox, so this should now work in theory, but it still doesn't work after I reverted the change that disabled devtools over in https://github.com/mykmelez/qbrt/tree/reenable-devtools. So I'm unsure what else is broken. Nevertheless, I still think that the better solution is to integrate devtools via https://github.com/devtools-html/devtools, once that becomes available (assuming it does become available), rather than hackily using the devtools instance built into Firefox. |
@mykmelez A fix for this would be welcome. This limitation (and other regressions) forced me to switch to Electron :( |
I took another look tonight and resolved the regressions, so DevTools will be back once #153 lands. That being said, the integration remains brittle and prone to bustage. We'll really need something better. Unfortunately, I don't think #101 is going to be that thing, as the DevTools Go Faster project doesn't seem to have happened. |
I can confirm this is working again, thank you! Now I can debug some other problems... |
https://bugzilla.mozilla.org/show_bug.cgi?id=1352595 broke postinstallation, which expands Firefox's omni.ja file in order to reuse its devtools.
I don't know of an easy fix; presumably we'd need to find (or build) a ZIP archive expander that knows how to decompress files compressed with the Brotli algorithm.
Probably the better solution is to integrate devtools via https://github.com/devtools-html/devtools, once that becomes available.
The text was updated successfully, but these errors were encountered: