Conversation
Contributor
Author
|
@craigcook This is up to date code, but the doc still need work. If you want you can take a preliminary look at the code. (also it needs a rebase) |
stephaniehobson
force-pushed
the
block
branch
5 times, most recently
from
826c158 to
0454393
Compare
Contributor
Author
|
I removed the cool JS configuration widget for now and am calling this ready. |
stephaniehobson
added
Review: L
craigcook
approved these changes
Apr 1, 2021
Contributor
craigcook
left a comment
craigcook
left a comment
There was a problem hiding this comment.
Not seeing any major issues, just some minor things that could be tidied up. We should definitely add more to the docs but that can happen in a follow-up (so can the tidying for that matter). r+wc. Nice work! 👾
stephaniehobson
force-pushed
the
block
branch
4 times, most recently
from
ca95ad3 to
069d73e
Compare
craigcook
suggested changes
Apr 1, 2021
| - layout positioning classes: `mzp-l-split-reversed` | ||
| - body positioning classes: (horizontally left aligned by default), `mzp-l-split-h-center`, `mzp-l-split-h-end`, `mzp-l-split-v-start`, (verticallly centered by default), `mzp-l-split-v-end` | ||
| - media sizing classes: `mzp-l-split-media-overflow`, `mzp-l-split-media-constrain-height` | ||
| - media positioning classes: (horizontally left aligned by default), `mzp-l-split-h-center`, `mzp-l-split-h-end`, `mzp-l-split-v-start`, (verticallly centered by default), `mzp-l-split-v-end` |
Contributor
There was a problem hiding this comment.
Another one
Suggested change
| - media positioning classes: (horizontally left aligned by default), `mzp-l-split-h-center`, `mzp-l-split-h-end`, `mzp-l-split-v-start`, (verticallly centered by default), `mzp-l-split-v-end` | |
| - media positioning classes: (horizontally left aligned by default), `mzp-l-split-h-center`, `mzp-l-split-h-end`, `mzp-l-split-v-start`, (vertically centered by default), `mzp-l-split-v-end` |
| - note that the media can only be positioned horizontally if it does not have a sizing class added | ||
| - "pop" the media out of the container with: `mzp-l-split-pop-top`, `mzp-l-split-pop-bottom`, `mzp-l-split-pop` | ||
| - mobile display classes: `mzp-l-split-center-on-sm-md`, `mzp-l-split-hide-media-on-sm-md` | ||
| - No default typography styles are applied to the body text, use atoms to achive the desired content and apperance. |
Contributor
There was a problem hiding this comment.
Suggested change
| - No default typography styles are applied to the body text, use atoms to achive the desired content and apperance. | |
| - No default typography styles are applied to the body text; use atoms to achieve the desired content and appearance. |
craigcook
approved these changes
Apr 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.l-reverseDescription
Adds a new component to replace hero, feature, and billboard.
CHANGELOG.md.Issue
Fix #326
Testing