Adjust line heights to match brand guidelines#1080
Merged
stephaniehobson merged 2 commits intomainfrom Aug 13, 2025
Merged
Conversation
stephaniehobson
force-pushed
the
typography
branch
from
40c5931 to
059e71b
Compare
stephaniehobson
added
Needs:Review 👋
maureenlholland
approved these changes
Aug 12, 2025
Collaborator
maureenlholland
left a comment
maureenlholland
left a comment
There was a problem hiding this comment.
r+wc
one rogue 1.15 value in condensed scale, otherwise LGTM
| --body-sm-size: 0.75rem; | ||
| --body-xs-size: 0.688rem; | ||
| --body-line-height: 1.2; | ||
| --body-line-height: 1.25; |
Collaborator
There was a problem hiding this comment.
future thought (non-blocking): for regular scale Body XS and condensed scale Body SM & XS, we are at 12px or lower font size with default settings. Wondering if we need to specify the small body copy line height somewhere
Suggested change
| --body-line-height: 1.25; | |
| --body-line-height: 1.25; | |
| --body-sm-line-height: 1.4; |
maureenlholland
removed
Needs:Review 👋
Co-authored-by: maureenlholland <19650432+maureenlholland@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjust line heights in Mozilla theme to match brand guidelines
CHANGELOG.md.Issue
https://github.com/mozilla/protocol/issues/10a37#issuecomment-3104777682
Testing
http://localhost:3000/components/detail/headings