Skip to content

Update protocol-assets and publish V21 #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephaniehobson merged 2 commits into from
May 2, 2025
Merged

Update protocol-assets and publish V21 #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29cfb2b
Update protocol-assets and publish V21
stephaniehobson Apr 22, 2025
ed6abad
Update CHANGELOG.md
stephaniehobson May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,20 @@
# HEAD
# 21.0.0

## Features

* **assets:** (breaking) Update @mozilla-protocol/assets to 6.0.1
* **css:** Update navigation and footer with Mozilla logo lockup.

## Bug Fixes

* **css:** Notification bar padding of links only working for complete sentences (#1000)
* **css:** Missing explicit `mzp-c-notification-bar-cta` distinction (#1041)
* **css:** Fix logo size in navigation in Firefox variant on large screen
Copy link
Collaborator

@maureenlholland maureenlholland Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch


## Migration Tips
Copy link
Collaborator

@maureenlholland maureenlholland Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


* The new Mozilla wordmark files are the same height but longer. If you are explicitly declaring a width for them, you should update it (Tip: check your CSS background images too.)
* The flat logo files are no longer square, so check their dimensions too (social files remain square)

# 20.0.0

Expand Down
2 changes: 1 addition & 1 deletion assets/package/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Install package with NPM and add it to your dependencies:
</tr>
<tr>
<td>Version</td>
<td><a href="https://github.com/mozilla/protocol/blob/main/CHANGELOG.md">20.0.0</a></td>
<td><a href="https://github.com/mozilla/protocol/blob/main/CHANGELOG.md">21.0.0</a></td>
</tr>
<tr>
<td>Releases</td>
Expand Down
2 changes: 1 addition & 1 deletion assets/package/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mozilla-protocol/core",
"version": "20.0.0",
"version": "21.0.0",
"description": "A design system for Mozilla's websites.",
"repository": {
"type": "git",
Expand Down
7 changes: 3 additions & 4 deletions assets/sass/protocol/components/_footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,12 @@
margin-bottom: $spacing-xl;

a {
background: url('#{$image-path}/logos/mozilla/logo-word-hor-white.svg') no-repeat;

@include background-size(100px, 32px);
background: url('#{$image-path}/logos/mozilla/logo-lockup-hor-white.svg') no-repeat;
@include background-size(134px, 32px);
@include image-replaced;
display: inline-block;
height: 32px;
width: 100px;
width: 134px;
}
}

Expand Down
14 changes: 4 additions & 10 deletions assets/sass/protocol/components/_navigation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,14 @@
@include bidi(((float, left, right),));

a {
@include background-size(84px, 24px);
@include background-size(101px, 24px);
@include image-replaced;
background-image: url('#{$image-path}/logos/mozilla/logo-word-hor.svg');
background-image: url('#{$image-path}/logos/mozilla/logo-lockup-hor.svg');
background-repeat: no-repeat;
display: block;
height: 24px;
margin: 0 auto;
width: 84px;
width: 101px;
}

@media #{$mq-md} {
Expand All @@ -98,13 +98,6 @@

@media #{$mq-lg} {
@include bidi(((margin, $spacing-lg ($spacing-md * 2) $spacing-lg 0, $spacing-lg 0 $spacing-lg ($spacing-md * 2)),));

a {
@include background-size(112px, 32px);
height: 32px;
margin-top: $spacing-xs;
width: 112px;
}
}

@media #{$mq-xl} {
Expand All @@ -127,6 +120,7 @@

@media #{$mq-lg} {
a {
@include background-size(109px, 36px);
background-image: url('#{$image-path}/logos/firefox/logo-word-hor.svg');
height: 36px;
margin-top: 1px;
Expand Down
12 changes: 6 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "protocol",
"version": "20.0.0",
"version": "21.0.0",
"private": true,
"author": "Mozilla",
"description": "A design system for Mozilla's websites.",
Expand Down Expand Up @@ -32,7 +32,7 @@
"@frctl/fractal": "^1.5.15",
"@frctl/mandelbrot": "^1.10.3",
"@frctl/nunjucks": "^2.0.15",
"@mozilla-protocol/assets": "^5.4.0",
"@mozilla-protocol/assets": "^6.0.1",
"@mozilla-protocol/tokens": "^6.0.0",
"babel-loader": "^10.0.0",
"clean-webpack-plugin": "^4.0.0",
Expand Down