Skip to content

Bump sinon from 19.0.2 to 20.0.0 #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexgibson merged 2 commits into from
Apr 15, 2025
Merged

Bump sinon from 19.0.2 to 20.0.0 #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db7a4a2
Bump sinon from 19.0.2 to 20.0.0
dependabot[bot] Apr 3, 2025
b8ba3dc
Use Jasmine spyOn() instead of sinon.useFakeXMLHttpRequest()
alexgibson Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 10 additions & 43 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"eslint": "^9.23.0",
"jasmine-browser-runner": "^3.0.0",
"jasmine-core": "^5.6.0",
"sinon": "^19.0.2",
"sinon": "^20.0.0",
"stylelint": "^16.17.0",
"stylelint-config-standard-scss": "^14.0.0"
},
Expand Down
91 changes: 56 additions & 35 deletions tests/unit/newsletter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,18 +98,33 @@ describe('MzpNewsletter', function () {
});

describe('form submission', function () {
let xhr;
let xhrRequests = [];

beforeEach(function () {
xhr = sinon.useFakeXMLHttpRequest();
xhr.onCreate = (req) => {
xhrRequests.push(req);
xhrRequests = [];

function FakeXHR() {
this.headers = {};
this.readyState = 0;
this.status = 0;
this.responseText = '';
this.onload = null;

xhrRequests.push(this);
}

FakeXHR.prototype.open = jasmine.createSpy('open');
FakeXHR.prototype.setRequestHeader = function (header, value) {
this.headers[header] = value;
};
FakeXHR.prototype.send = jasmine.createSpy('send');

spyOn(window, 'XMLHttpRequest').and.callFake(function () {
return new FakeXHR();
});
});

afterEach(function () {
xhr.restore();
xhrRequests = [];
});

Expand All @@ -121,11 +136,12 @@ describe('MzpNewsletter', function () {
document.getElementById('id_lang').value = 'en';
document.getElementById('privacy').click();
document.getElementById('newsletter-submit').click();
xhrRequests[0].respond(
200,
{ 'Content-Type': 'application/json' },
'{"status": "ok"}'
);

const req = xhrRequests[0];
req.status = 200;
req.readyState = 4;
req.responseText = '{"status": "ok"}';
req.onload({ target: req });

expect(MzpNewsletter.handleFormSuccess).toHaveBeenCalled();
expect(
Expand All @@ -148,11 +164,12 @@ describe('MzpNewsletter', function () {
document.getElementById('id_lang').value = 'en';
document.getElementById('privacy').click();
document.getElementById('newsletter-submit').click();
xhrRequests[0].respond(
400,
{ 'Content-Type': 'application/json' },
'{"status": "error", "desc": "Invalid email address"}'
);

const req = xhrRequests[0];
req.status = 400;
req.readyState = 4;
req.responseText = '{"status": "error", "desc": "Invalid email address"}';
req.onload({ target: req });

expect(MzpNewsletter.handleFormError).toHaveBeenCalledWith(
'Invalid email address'
Expand Down Expand Up @@ -271,11 +288,12 @@ describe('MzpNewsletter', function () {
document.getElementById('id_lang').value = 'en';
document.getElementById('privacy').click();
document.getElementById('newsletter-submit').click();
xhrRequests[0].respond(
400,
{ 'Content-Type': 'application/json' },
'{"status": "error", "desc": "Unknown non-helpful error"}'
);

const req = xhrRequests[0];
req.status = 400;
req.readyState = 4;
req.responseText = '{"status": "error", "desc": "Unknown non-helpful error"}';
req.onload({ target: req });

expect(MzpNewsletter.handleFormError).toHaveBeenCalled();
expect(
Expand All @@ -298,11 +316,12 @@ describe('MzpNewsletter', function () {
document.getElementById('id_lang').value = 'en';
document.getElementById('privacy').click();
document.getElementById('newsletter-submit').click();
xhrRequests[0].respond(
500,
{ 'Content-Type': 'application/json' },
null
);

const req = xhrRequests[0];
req.status = 500;
req.readyState = 4;
req.responseText = null;
req.onload({ target: req });

expect(MzpNewsletter.handleFormError).toHaveBeenCalled();
expect(
Expand Down Expand Up @@ -334,11 +353,12 @@ describe('MzpNewsletter', function () {
document.getElementById('id_lang').value = 'en';
document.getElementById('privacy').click();
document.getElementById('newsletter-submit').click();
xhrRequests[0].respond(
200,
{ 'Content-Type': 'application/json' },
'{"status": "ok"}'
);

const req = xhrRequests[0];
req.status = 200;
req.readyState = 4;
req.responseText = '{"status": "ok"}';
req.onload({ target: req });

expect(MzpNewsletter.handleFormSuccess).toHaveBeenCalled();
expect(testObj.successCallback).toHaveBeenCalled();
Expand All @@ -361,11 +381,12 @@ describe('MzpNewsletter', function () {
document.getElementById('id_lang').value = 'en';
document.getElementById('privacy').click();
document.getElementById('newsletter-submit').click();
xhrRequests[0].respond(
500,
{ 'Content-Type': 'application/json' },
null
);

const req = xhrRequests[0];
req.status = 500;
req.readyState = 4;
req.responseText = null;
req.onload({ target: req });

expect(MzpNewsletter.handleFormError).toHaveBeenCalled();
expect(testObj.errorCallback).toHaveBeenCalled();
Expand Down