Move LocaleSelector to locale module#4265
Open
MundiaNderi wants to merge 1 commit into
Open
Conversation
Move LocaleSelector to locale module
mathjazz
reviewed
Jun 30, 2026
Collaborator
There was a problem hiding this comment.
Thanks for the patch!
Please also:
- factor out the relevant CSS rules into the
localemodule - add/move relevant tests to the
localemodule
What are your thoughts of splitting the component into LocaleMenu and LocaleItem components, which is what we do for the project and resource components?
Collaborator
Author
I'll look into this in depth and revert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4263
Makes the component reusable outside of batch actions.
To test: Check the file structure and run associated tests.