Skip to content

Clean up batch actions code#4194

Merged
mathjazz merged 1 commit into
mozilla:mainfrom
eemeli:fix-batch
Jun 30, 2026
Merged

Clean up batch actions code#4194
mathjazz merged 1 commit into
mozilla:mainfrom
eemeli:fix-batch

Conversation

@eemeli

@eemeli eemeli commented Jun 8, 2026

Copy link
Copy Markdown
Member

Minor cleanup, mostly focused on getting rid of the ACTIONS_FN_MAP that adds unnecessary indirection when handling batch actions.

@eemeli eemeli requested a review from mathjazz June 8, 2026 04:51
@codecov-commenter

codecov-commenter commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.99%. Comparing base (6e9f24a) to head (8cfaefe).

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mathjazz mathjazz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation for this change?

It will likely clash with #4152, which has been open for a while.

@eemeli

eemeli commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

Got annoyed at how much indirection I had to work through while figuring out if some of the changes I was applying required changes to the batch actions code.

I don't really have anything blocking on this, so would be happy to leave it open and see about resolving merge conflicts after #4152 is merged.

@mathjazz

Copy link
Copy Markdown
Collaborator

@eemeli Could you please rebase?

@mathjazz mathjazz merged commit 28e94ec into mozilla:main Jun 30, 2026
3 checks passed
@eemeli eemeli deleted the fix-batch branch June 30, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants