Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject translations removed from repo #3564

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Reject translations removed from repo #3564

wants to merge 2 commits into from
+36 −28

Conversation

eemeli
Copy link
Member

@eemeli eemeli commented Feb 11, 2025

Fixes #3516

I've only validated this via the test suite, but checking with real-ish syncs as well would be good (CC @flodolo).

@eemeli eemeli requested a review from mathjazz February 11, 2025 15:11
@flodolo
Copy link
Collaborator

flodolo commented Feb 11, 2025 •
edited
Loading

Can you test it on an actual repo?

  1. Fork https://github.com/mozilla-l10n/pontoon-test and set up a project against it
  2. Remove one translation from the repo for one of the languages (bonus points for doing it on multiple formats).

@eemeli
Copy link
Member Author

eemeli commented Feb 12, 2025

Can you test it on an actual repo?

Done. Identified one now extraneous warning that needed dropping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathjazz mathjazz Awaiting requested review from mathjazz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strings removed from repository are still displayed as translated
2 participants
@eemeli @flodolo