Pontoon commits .properties strings with line break as junk

[bugzilla-to-github]

This issue was created automatically by a script.

Bug 1611667

Bug Reporter: @flodolo
CC: @Pike, @Pike
Depends on: Bug 1696486

It happened at least twice in the last week: translation in a .properties file including a line break is serialized as is, resulting in junk.

https://hg.mozilla.org/l10n-central/hy-AM/rev/6552dfee38b49517c83a31ac2fd888cf4bf3056a

The new line should be replaced by a \

[bugzilla-to-github]

Comment Author: @Pike

Do you know if this ever worked? I glanced at both silme and pontoon, and I haven't found the culprit I was looking for (py3 backslash escapes changing)

[bugzilla-to-github]

Comment Author: @flodolo

My assumption is that it's unrelated to Python 3, and it's just a coincidence (hy-AM has thousands of unreviewed suggestions being approved, and apparently this person sometimes adds newline in .properties).

[bugzilla-to-github]

Comment Author: @Pike

Having looked at sync a bit today (sadly), I think this is really about checks not catching this.

If we convert sync to c-l in bug #1696486, it'll be useful to also convert checks to serialize-parse, and then we'd catch problems like this.

Getting good error messages would be a challenge on top, as always.

[mathjazz]

Looks like this still needs to be fixed?
mozilla-l10n/pontoon-test@3239d50

@eemeli ?

[eemeli]

Yeah, the current serialization relies on the value stored in the database being safe to serialize, which isn't true for .properties messages with newlines. There should be a .replace('\n', '\\n') done on the Pontoon side for this.

[flodolo]

Actually, let's assume this was verified and it's a regression.