Fix worker resolution on using minified version #8262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcorral
commented
Apr 10, 2017
tcorral
commented
- When the minified version is used the resolver of the worker can not find it properly and throws 404 error.
- The problem was that:
- It was getting the current name of the file.
- It was replacing .js by .worker.js
- When it was loading the unminified version it was working fine because:
- pdf.js - .js + .worker.js = pdf.worker.js
- When it was loading the minified version it didtn't work because:
- pdf.min.js - .js + .worker.js = pdf.min.worker.js
- pdf.min.worker.js doesn't exist the real file name is pdf.worker.min.js
- When the minified version is used the resolver of the worker can not find it properly and throws 404 error. - The problem was that: - It was getting the current name of the file. - It was replacing **.js** by **.worker.js** - When it was loading the unminified version it was working fine because: - *pdf.js - .js + .worker.js* = **pdf.worker.js** - When it was loading the minified version it didtn't work because: - *pdf.min.js - .js + .worker.js* = **pdf.min.worker.js** - **pdf.min.worker.js** doesn't exist the real file name is **pdf.worker.min.js**
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/34e8aefb10ac767/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/34e8aefb10ac767/output.txt Total script time: 2.75 mins Published |
|
Thank you. |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Fix worker resolution on using minified version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.