[api-minor] Add support for /AuthEvent, on-demand decryption#21351
Open
wooorm wants to merge 5 commits into
Open
[api-minor] Add support for /AuthEvent, on-demand decryption#21351wooorm wants to merge 5 commits into
/AuthEvent, on-demand decryption#21351wooorm wants to merge 5 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21351 +/- ##
==========================================
- Coverage 81.45% 81.42% -0.03%
==========================================
Files 260 260
Lines 65805 65908 +103
==========================================
+ Hits 53600 53666 +66
- Misses 12205 12242 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+33
to
+39
| /** | ||
| * @import { | ||
| * CatalogAttachmentContent, | ||
| * CatalogAttachment | ||
| * } from "../core/catalog.js"; | ||
| */ | ||
|
|
Collaborator
There was a problem hiding this comment.
Here, and in other places as well, please note that code residing in src/core/ runs in a worker-thread whereas code in src/display/ runs in the main-thread.
Hence, given how data is being cloned when sent between threads, what ends up in the main-thread is essentially a "proxy" to the worker-thread data and not actually the same type.
Collaborator
Author
There was a problem hiding this comment.
The values I get here are the same type as there? 🤔
Snuffleupagus
changed the title
/AuthEvent, on-demand decryption/AuthEvent, on-demand decryption
Normally entire PDFs are encrypted (or not). But it is also possible to only encrypt attachments. It is then also possible to *only* prompt for a password when the user opens them. In the existing flow, prompting for passwords happens because things are decrypted. A specific error is thrown, caught, and the user is prompted. To keep this flow working, this PR changes to decrypting attachments on demand, instead of eagerly. This sounds logical: to not read attachments on startup. I’ve extensively tested this, not only with regular attachments, but also with outline items and attachments in annotations. This PR builds on mozillaGH-21234. It’s an alternative to the naïve mozillaGH-20732. Closes mozillaGH-20049.
wooorm
force-pushed
the
wooorm/auth-event-and-encrypted-attachments
branch
from
f91d1bf to
2bd5c04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This branch also includes the commit from GH-21234, but that’s supposed to land separately, first.)
Normally entire PDFs are encrypted (or not).
But it is also possible to only encrypt attachments.
It is then also possible to only prompt for a password when the user opens
them.
In the existing flow, prompting for passwords happens because things are decrypted.
A specific error is thrown, caught, and the user is prompted.
To keep this flow working, this PR changes to decrypting attachments on demand,
instead of eagerly.
This sounds logical: to not read attachments on startup.
I’ve extensively tested this, not only with regular attachments, but also with outline items
and attachments in annotations.
This PR builds on GH-21234.
It’s an alternative to the naïve GH-20732.
Closes GH-20049.